[TypeScript] Split composed types in new addImports() method #11719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6430aaf introduced additional paths to add imports when resolving a deeply-nested object. The override in
AbstractTypeScriptClientCodegen
which splits composed types is not always hit, so this causes imports looking like:The versions don't match up (this change was introduced in
5.4.0
), but this is the same bug as #9163 describes, from what I can tell.If necessary, I can open a different bug.
Also, I have made this PR against
5.4.x
, merging changes from thev5.4.0
tag that weren't in that branch for whatever reason. It applies cleanly tomaster
as well, so if no patch is planned for5.4.x
, I can rebase tomaster
.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
5.4.x
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)