Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript] Split composed types in new addImports() method #11719

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sarumont
Copy link
Contributor

@sarumont sarumont commented Feb 25, 2022

6430aaf introduced additional paths to add imports when resolving a deeply-nested object. The override in AbstractTypeScriptClientCodegen which splits composed types is not always hit, so this causes imports looking like:

import {Foo & Bar} from '.';

The versions don't match up (this change was introduced in 5.4.0), but this is the same bug as #9163 describes, from what I can tell.

If necessary, I can open a different bug.

Also, I have made this PR against 5.4.x, merging changes from the v5.4.0 tag that weren't in that branch for whatever reason. It applies cleanly to master as well, so if no patch is planned for 5.4.x, I can rebase to master.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: 5.4.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

@macjohnny macjohnny changed the base branch from 5.4.x to master March 2, 2022 07:27
Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution!
can you add a test in e.g. modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/fetch/TypeScriptFetchModelTest.java?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants