Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined object in Python model __copy__ template #11792

Merged

Conversation

tuanchien
Copy link
Contributor

Implements the recommended fix for issue #10856, a Python client bug in the mustache template that causes model copies to fail due to trying to return an undefined object.

Changes the template for the __copy__ method to return cls.__new__(cls, **self.__dict__) instead of new_cls.__new__(cls, **self.__dict__)

Tagging Python committee:
@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether added this to the 6.0.0 milestone Mar 7, 2022
@spacether
Copy link
Contributor

Closing and re opening to kick off ci

@spacether spacether closed this Mar 9, 2022
@spacether spacether reopened this Mar 9, 2022
@spacether
Copy link
Contributor

@tuanchien please fix the CI tests that are failing. I need them to be passing before I can approve and merge your PR.

@tuanchien tuanchien force-pushed the bugfix/10856-fix-new_cls-template branch 2 times, most recently from 2a59467 to f684ae5 Compare March 11, 2022 06:05
@tuanchien tuanchien closed this Mar 11, 2022
@tuanchien tuanchien reopened this Mar 11, 2022
@tuanchien
Copy link
Contributor Author

@spacether I've rebased the latest master onto this branch and re-run bin/generate-samples.sh

Might need you to rerun the tests. The failures for node0,1,2 look related to the CI servers.

@tuanchien tuanchien force-pushed the bugfix/10856-fix-new_cls-template branch 2 times, most recently from fcd7b34 to e75325b Compare March 15, 2022 09:52
@tuanchien tuanchien force-pushed the bugfix/10856-fix-new_cls-template branch from e75325b to 098762e Compare March 17, 2022 06:26
@tuanchien
Copy link
Contributor Author

@spacether Rebased again off master today. All tests passing.

Copy link
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the PR!

@spacether spacether merged commit 1fe2eb6 into OpenAPITools:master Mar 19, 2022
@tuanchien tuanchien deleted the bugfix/10856-fix-new_cls-template branch March 20, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants