-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java][Micronaut] generator fixes #11803
Conversation
…with application settings when special characters are present
...generator/src/main/java/org/openapitools/codegen/languages/JavaMicronautAbstractCodegen.java
Outdated
Show resolved
Hide resolved
Hi @oujesky, all the changes are reasonable and make sense. Thank you for this PR. ./mvnw clean package -DskipTests
./mvnw package integration-test -P java-micronaut-client -P java-micronaut-server I have noticed that there are some errors for the generated micronaut client as a sample. <dependency>
<groupId>io.micronaut.xml</groupId>
<artifactId>micronaut-jackson-xml</artifactId>
<scope>compile</scope>
</dependency> The other error I encountered is that xml of empty list gets parsed as |
@oujesky can you please resolve the merge conflicts when you've time? |
@@ -74,6 +75,7 @@ class PetApiSpec extends Specification { | |||
* Finds Pets by status | |||
* Multiple status values can be provided with comma separated strings | |||
*/ | |||
@Ignore("Issue reported in https://github.com/micronaut-projects/micronaut-jackson-xml/issues/175") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This and the next test failed because of the issue reported in micronaut-projects/micronaut-jackson-xml#175:
phototoUrls
is an empty set, but is deserialized as set with an empty String ([""]
). No changes are required on the openapi generator side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. LGTM
* master: update gson to newer version in kotlin templates (OpenAPITools#12425) update gson to 2.8.9 in android httpclient (OpenAPITools#12423) update android dependencies to newer versions (OpenAPITools#12421) [Java] Update rest-assured dependencies (OpenAPITools#12420) update cwiki samples Add - Status colors in Wiki, Example per parameter (OpenAPITools#12394) Better support for inline schemas in parameters (OpenAPITools#12369) Upgrade Spring Boot to 2.5.14 / 2.7.0 (OpenAPITools#12408) update java samples Remove javadoc comment for unthrown IOException (OpenAPITools#12401) remove errorObjectSubtype from java client genreator (OpenAPITools#12405) [java][Micronaut] generator fixes (OpenAPITools#11803) Apply style and explode values from encoding for form-encoded request body parameters (OpenAPITools#12162)
Minor fixes for Micronaut generator:
@Consumes
and@Produces
annotationscc @andriy-dmytruk
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x