[csharp-netcore] Fix incorrect FileParameter deserialization #11850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10588.
OpenAPI responses with binary content have a method generated that returns a
FileParameter
with the csharp-netcore generator, but this type can't actually be deserialized properly when the call is made, resulting in an error. The type is simply a wrapper for a stream, so reading the stream and creating theFileParameter
is sufficient to fix the problem.Testing done is that we've tried this fix proposed in #10588 successfully and are using it in production with an OpenAPI that has the following 200 response definition for a GET request that downloads a file:
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x