Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes double 'String' on string & UUID type #12409

Merged
merged 1 commit into from
May 26, 2022
Merged

Fixes double 'String' on string & UUID type #12409

merged 1 commit into from
May 26, 2022

Conversation

taufik-rama
Copy link
Contributor

@taufik-rama taufik-rama commented May 20, 2022

Continuation from #10569, I just fixed the remaining place where it's needed (Edit: it seems that that changes got reverted. I double-checked & had to do more-or-less the same changes)

I've tested this changes by building the Dockerfile & regenerating my projects, it worked fine

Before

/// struct for passing parameters to the method [`users_delete`]
#[derive(Clone, Debug, Default)]
pub struct UsersDeleteParams {
    pub id: Option<StringString>,
    // ...
}

After

/// struct for passing parameters to the method [`users_delete`]
#[derive(Clone, Debug, Default)]
pub struct UsersDeleteParams {
    pub id: Option<String>,
}

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @paladinzh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants