[rust] fix unusable oneOf generation #12566
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the combined oneOf struct ensure the struct can form a valid request.
Reproduction steps:
java -jar ./modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -g rust -i ./openapi.yaml
./src/models/foo.rs
Expected behavior: Able to fill in struct fields in such a way that creates a valid request
Actual behavior: Impossible to fill the struct Foo to make it a valid schema (as BOTH required fields (field_one and field_three) are required to be filled in rust, yet the openapi schema only allows one or the other to be set.
Related issue: #9497
Ideally oneOf would be represented as an enum. Presently the oneOf implementation is unusable (as described by @cortopy), this PR would at least makes it usable, but requires the rust api consumer to know what a valid schema object is (aka which optional types to populate to form a valid response).
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.0.1) (patch release),6.1.x
(breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)