Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA] Fix compilation error in Enum model generation that contains boolean property #13569

Closed
wants to merge 1 commit into from

Conversation

vithu30
Copy link
Contributor

@vithu30 vithu30 commented Oct 2, 2022

Fixes #9005

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@SergeyManetskiy
Copy link

Hi there,
will the fix be merged?

@vithu30
Copy link
Contributor Author

vithu30 commented Dec 14, 2022

@wing328
Copy link
Member

wing328 commented Feb 21, 2023

I just added a new rule in the openapi normalizer to simplify boolean enum into just boolean :#14764.

Please give it a try to see if it fixes the issue.

@wing328
Copy link
Member

wing328 commented Mar 13, 2023

closing this as there's no update.

@wing328 wing328 closed this Mar 13, 2023
@vithu30
Copy link
Contributor Author

vithu30 commented Mar 14, 2023

I just added a new rule in the openapi normalizer to simplify boolean enum into just boolean :#14764.

Please give it a try to see if it fixes the issue.

Hi @wing328,
Any reason to fix it during generation rather using template file?

@wing328
Copy link
Member

wing328 commented Mar 14, 2023

if you prefer updating the template, you can use customize templates (e.g. -t option in the CLI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Java] Error when using property of type boolean with enum
3 participants