-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript-axios] Upgrade to axios@^1 #14518
[typescript-axios] Upgrade to axios@^1 #14518
Conversation
It looks like this is a breaking change, so can you change the target branch to 7.0.0? Or we could introduce an option similar to the version in the typescript-angular generator |
Yeah. It is. Do you prefer an option, which you can then change to be default in v7, or to do this for v7 only? |
If you are fine waiting for 7.0.0 to be released, lets do it without introducing an option, see https://github.com/OpenAPITools/openapi-generator/milestones |
bcf4d1c
to
b02e31c
Compare
@macjohnny Rebased to 7.0.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks for your contribution!
can you have a look at the error
|
Seems like something with |
Hi :) any update on this PR ? thanks |
@segevfiner can you please merge the most recent master, resolve the conflicts and fix the tests? |
@@ -22,7 +22,7 @@ | |||
"prepare": "npm run build" | |||
}, | |||
"dependencies": { | |||
"axios": "^0.26.1" | |||
"axios": "^1.2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to 1.4.0 if possible 1.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to update to 1.6.0. Previous versions contain CSRF vulnerability
@segevfiner I don't have access to CircleCI for some reason, but I am happy to help here. Can you try to rebase it again, while I try to be able to check the failed tests please? :) |
66da168
to
ed24a9f
Compare
Rebased. It looks like the tests expect axios to get hoisted, but it doesn't get hoisted... |
Tried modifying the setup there to depend on |
Awesome stuff @segevfiner / @macjohnny ! Is there any idea about when it will be generally available please? :) Thanks! |
* [typescript-axios] Upgrade to axios@^1 * Try fixing tests
Fixes #14517, we need to consider if this is a breaking change or not in terms of OpenAPI generator versioning.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)