Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Jaxrs][Resteasy] add @Valid to getter methods, updated #15064

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

martin-mfg
Copy link
Contributor

closes #1698

This PR is based on @tnmtechnologies' work in #2039. On top of their changes I made some whitespace changes, to address the remaining comments in #2039.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608

@wing328 wing328 changed the title [JavaJaxrsResteasy] add @Valid to getter methods, updated [Java][Jaxrs][Resteasy] add @Valid to getter methods, updated May 11, 2023
@wing328 wing328 added this to the 7.0.0 milestone May 11, 2023
@@ -1,4 +1,5 @@
import io.swagger.annotations.*;
{{#useBeanValidation}}import javax.validation.Valid;{{/useBeanValidation}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI. You can do the following to avoid a blank line if useBeanValidation is not true

{{#useBeanValidation}}
import javax.validation.Valid;
{{/useBeanValidation}}

@wing328 wing328 merged commit 17f1d35 into OpenAPITools:master Jun 8, 2023
makru86 pushed a commit to makru86/openapi-generator that referenced this pull request Jun 12, 2023
…ITools#15064)

* [JavaJaxrsResteasy] add @Valid to getter methods

* improve whitespacing

---------

Co-authored-by: TNM Technologies <tnmtechnologies@users.noreply.github.com>
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
…ITools#15064)

* [JavaJaxrsResteasy] add @Valid to getter methods

* improve whitespacing

---------

Co-authored-by: TNM Technologies <tnmtechnologies@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java][jaxrs/resteasy] add @Valid to getter methods when bean validation is enabled
3 participants