Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] default values escaping more appropriate #15695

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

HeikoStudt
Copy link
Contributor

Fixes #15541

Default Value: Backslash value needs an escaped backslash in generated python code.
Single quotes needs escapng on multilines as well (at least if there were three in a row)

Added a small unit test.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    Commit all changed files.
  • [~] In case you are adding a new generator, run the following additional script :
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @spacether @krjakbrjak

@HeikoStudt
Copy link
Contributor Author

The failed test seems to be infrastructure (NPM download failed)

@wing328
Copy link
Member

wing328 commented Jun 5, 2023

all tests passed

@wing328 wing328 merged commit 5866264 into OpenAPITools:master Jun 10, 2023
makru86 pushed a commit to makru86/openapi-generator that referenced this pull request Jun 12, 2023
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Python] DefaultValue does not escape backslash
2 participants