Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kotlin][Spring] remove @RequestMapping in Feign client #15898

Conversation

ctbarnev
Copy link
Contributor

@ctbarnev ctbarnev commented Jun 22, 2023

PR checklist

  • Read the contribution guidelines.

  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.

  • Run the following to build the project and update samples:

    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    

    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.

    Commit all changed files.

  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)

  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)

Description:
Running application with generated Feign client fails with this error: @RequestMapping annotation not allowed on @FeignClient interfaces.

Configuration:

generatorName: kotlin-spring
inputSpec: ./openapi.yaml
outputDir: ./generated/spring
additionalProperties:
  library: spring-cloud
  useTags: true
  skipDefaultInterface: true
  gradleBuildFile: false
  useSpringBoot3: true

Currently generated interface:

@Validated
@RequestMapping("\${api.base-path:/api/test/v1}")
interface TestApi {

After this fix generated interface:

@Validated
interface TestApi {

With this fix in place it's possible to use the generated client from the Kotlin-Spring generator with library Spring-Cloud.

This fix is inspired by this MR #13546 and fixes this issue also for Kotlin-Spring instead only for Spring.

@ctbarnev ctbarnev changed the title ctbarnev_bugfix-13488-remove-request-mapping-from-for-Kotlin-spring-c… [Kotlin][Spring]ctbarnev_bugfix-13488-remove-request-mapping-from-for-Kotlin-spring-c… Jun 23, 2023
@ctbarnev
Copy link
Contributor Author

@wing328 can you maybe have a look?

@wing328
Copy link
Member

wing328 commented Jun 23, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

ctbarnev and others added 6 commits June 23, 2023 14:35
…uest-mapping-from-for-Kotlin-spring-cloud' into ctbarnev_bugfix-13488-remove-request-mapping-from-for-Kotlin-spring-cloud
…uest-mapping-from-for-Kotlin-spring-cloud' into ctbarnev_bugfix-13488-remove-request-mapping-from-for-Kotlin-spring-cloud
@ctbarnev
Copy link
Contributor Author

ctbarnev commented Jun 23, 2023

Didn't notice the commits were not linked to my Github account. Thank you for bringing this to my attention! @wing328!

I have now successfully linked the commits to my GitHub account. From my perspective, the merge request is ready and can be merged.

@wing328
Copy link
Member

wing328 commented Jun 29, 2023

can you please merge the latest master into your branch as those CI failures already addressed in the master?

…rator into ctbarnev_bugfix-13488-remove-request-mapping-from-for-Kotlin-spring-cloud
@ctbarnev
Copy link
Contributor Author

Just merged master into my branch, however sill one test fails: https://github.com/OpenAPITools/openapi-generator/actions/runs/5409565359/jobs/9830019133

I cannot find a connection between my changes and this failing build: Nodejs.org didn't respond fast enough causing one build to fail. Can we retry somehow? Of maybe increase timeouts if this happens too often?

@wing328
Copy link
Member

wing328 commented Jun 29, 2023

restarted and all good

@wing328 wing328 merged commit b2280e2 into OpenAPITools:master Jun 29, 2023
@wing328 wing328 changed the title [Kotlin][Spring]ctbarnev_bugfix-13488-remove-request-mapping-from-for-Kotlin-spring-c… [Kotlin][Spring] remove @RequestMapping in Feign client Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] @RequestMapping annotation not allowed on @FeignClient interfaces
2 participants