Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename inlineSchemaNameDefaults to inlineSchemaOptions #16048

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jul 10, 2023

Rename inlineSchemaNameDefaults to inlineSchemaOptions

e.g. --inline-schema-name-defaults => --inline-schema-options in the CLI

Rename suffix options from

--inline-schema-name-defaults arrayItemSuffix=_array_item,mapItemSuffix=_map_item

to

--inline-schema-options ARRAY_ITEM_SUFFIX=_array_item,MAP_ITEM_SUFFIX=_map_item,RESOLVE_INLINE_ENUMS=true

fyi @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added Breaking change (with fallback) Enhancement: General Inline Schema Handling Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf labels Jul 10, 2023
@wing328 wing328 added this to the 7.0.0 milestone Jul 10, 2023
@wing328 wing328 changed the title Rename InlineSchemaNameDefaults to InlineSchemaOptions Rename inlineSchemaNameDefaults to inlineSchemaOptions Jul 10, 2023
@wing328 wing328 merged commit 0a66710 into master Jul 11, 2023
13 checks passed
@wing328 wing328 deleted the inline-schema-options branch July 11, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change (with fallback) Enhancement: General Inline Schema Handling Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant