Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp] Update RestSharp to 110.2.0 #16122

Merged
merged 6 commits into from
Jul 21, 2023

Conversation

OfficialRenny
Copy link
Contributor

@OfficialRenny OfficialRenny commented Jul 18, 2023

Bumped RestSharp to the latest stable version (110.2.0), + changes in ApiClient.cs to fix a couple errors caused by breaking changes in RestSharp.

  • string ContentType(s) to RestSharp.ContentType ContentType(s).
  • new RestClient([..]).UseSerializer() moved into the configureSerialization delegate constructor parameter.
  • Moved the new RestResponse<T> Request initializer into the constructor as a RestRequest is now required.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. (@mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti)

@wing328
Copy link
Member

wing328 commented Jul 18, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Jul 18, 2023

Some CI jobs failed. Please take a look when you've time: https://github.com/OpenAPITools/openapi-generator/actions/runs/5589888558/jobs/10219041799?pr=16122

@OfficialRenny
Copy link
Contributor Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Ah, thanks for letting me know! Should be sorted now

@wing328
Copy link
Member

wing328 commented Jul 19, 2023

@wing328
Copy link
Member

wing328 commented Jul 21, 2023

appveyor tests passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/47603414

@wing328 wing328 merged commit bd76c1b into OpenAPITools:master Jul 21, 2023
@johnwc
Copy link

johnwc commented Jan 6, 2024

The documentation was never updated to reference the new version requirements, it still says 108+ is required.
https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator/src/main/resources/csharp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants