-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp] Update RestSharp to 110.2.0 #16122
[csharp] Update RestSharp to 110.2.0 #16122
Conversation
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Some CI jobs failed. Please take a look when you've time: https://github.com/OpenAPITools/openapi-generator/actions/runs/5589888558/jobs/10219041799?pr=16122 |
…/export_docs_generators.sh' scripts
e3fb810
to
0f16436
Compare
Ah, thanks for letting me know! Should be sorted now |
modules/openapi-generator/src/main/resources/csharp/ApiClient.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/csharp/ApiClient.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/csharp/ApiClient.mustache
Outdated
Show resolved
Hide resolved
FYI. appveyor C# tests passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/47582481 |
appveyor tests passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/47603414 |
The documentation was never updated to reference the new version requirements, it still says 108+ is required. |
Bumped RestSharp to the latest stable version (110.2.0), + changes in ApiClient.cs to fix a couple errors caused by breaking changes in RestSharp.
string
ContentType(s) toRestSharp.ContentType
ContentType(s).new RestClient([..]).UseSerializer()
moved into theconfigureSerialization
delegate constructor parameter.new RestResponse<T>
Request initializer into the constructor as a RestRequest is now required.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)