rust: fix rust generation of optional additionalProperties in openapi 3.1.0 #16143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16119
cc Rust technical committee: @frol @farcaller @richardwhiuk @paladinzh @jacob-pro
Fixes code generation for rust client models, when the generated type of the subfield is optional with
additionalProperties
, in openapi 3.1.0This PR inserts a default value
None
for the generated typeOption<Option<HashMap<K, V>>>
to fix what is currently a compilation error (please see #16119 for details, and reproducing the original issue).The root cause of the above bug seems to be that in the mustache template,
Option<T>
seems to be considered sometimesisContainer: true
and sometimesisContainer: false
depending on the value ofT
, leading to unexpected behaviour.This PR also contains a regression test for the issue, and adds this regression test to the relevant CI job. Please advise if this should be located/structured differently - I see
modules/openapi-generator/src/test/resources/bugs
already exists, but could not see it referenced in CI anywhere.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)