Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java GSON client not accepting optional null arrays #16213

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

MarcMil
Copy link
Contributor

@MarcMil MarcMil commented Jul 28, 2023

When the server responds with a null in JSON for an optional array, the GSON client refuses to accept it. Since the element is optional, it should simply continue.

Fixes #16212

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@wing328
Copy link
Member

wing328 commented Jul 30, 2023

@MarcMil thanks for the PR. Can you please add a test schema in modules/openapi-generator/src/test/resources/3_0/java/petstore-with-fake-endpoints-models-for-testing-okhttp-gson.yaml and update samples/client/petstore/java/okhttp-gson/src/test/java/org/openapitools/client/JSONTest.java to include a test?

@wing328
Copy link
Member

wing328 commented Aug 10, 2023

tested locally and the result is good. will add a test in another PR.

update: done via #16298

@wing328 wing328 merged commit 7a7309e into OpenAPITools:master Aug 10, 2023
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [JAVA] GSON client does not accept null in JSON for an optional array
2 participants