Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-nextgen] Fix allOf missing imports #16217

Merged
merged 5 commits into from
Jul 31, 2023

Conversation

fa0311
Copy link
Contributor

@fa0311 fa0311 commented Jul 28, 2023

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Overview

  • Fixed missing imports when superclass contains objects
  • Fixed implementation of superclass references, fixing errors caused by circular refs

Signed-off-by: ふぁ <yuki@yuki0311.com>
Signed-off-by: ふぁ <yuki@yuki0311.com>
Signed-off-by: ふぁ <yuki@yuki0311.com>
@fa0311 fa0311 changed the title Fix all of missing imports [python-nextgen] Fix allOf missing imports Jul 28, 2023
@fa0311
Copy link
Contributor Author

fa0311 commented Jul 28, 2023

Due to conflicts with other commit, this work will be done later.

Signed-off-by: ふぁ <yuki@yuki0311.com>
Signed-off-by: ふぁ <yuki@yuki0311.com>
@fa0311 fa0311 marked this pull request as ready for review July 30, 2023 19:00
@fa0311
Copy link
Contributor Author

fa0311 commented Jul 30, 2023

Fixed missing circular references and imports in allOf.
Resolves #16064 but https://cdn.intersight.com/components/an-apidocs/1.0.11-12738/model/intersight-openapi-v3-1.0.11-12738.json not yet available due to other errors

@wing328
Copy link
Member

wing328 commented Jul 31, 2023

Tested the fix with the spec you provided and was able to repeat the issue and confirm this fix.

Thanks again for the PR. I will add a test after merging this PR.

@wing328 wing328 merged commit 77311c3 into OpenAPITools:master Jul 31, 2023
11 checks passed
wing328 added a commit that referenced this pull request Jul 31, 2023
@wing328 wing328 mentioned this pull request Jul 31, 2023
6 tasks
wing328 added a commit that referenced this pull request Jul 31, 2023
* add tests for #16217

* add new files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants