Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 2 Sonar-reported bugs #16229

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

martin-mfg
Copy link
Contributor

Fix two bugs reported on SonarCloud. Hopefully, with these fixes, the build status of the master branch will be green again.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)

@wing328
Copy link
Member

wing328 commented Aug 2, 2023

thanks for the fix. let's see if the sonar reports pass

@wing328 wing328 merged commit 0ce1fef into OpenAPITools:master Aug 2, 2023
11 checks passed
@wing328 wing328 added this to the 7.0.0 milestone Aug 2, 2023
@wing328 wing328 added the Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. label Aug 2, 2023
@wing328
Copy link
Member

wing328 commented Aug 2, 2023

@martin-mfg when you've time, can you please PM me via Slack? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants