Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Microprofile - fix optional array property's default value #16500

Merged

Conversation

hightea
Copy link
Contributor

@hightea hightea commented Sep 4, 2023

Apply what has be done for optional array property's default value for microprofile ( #14961 did it for java , native and jersey, but not for microprofile)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (7.0.1 - patch release), 7.1.x (minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328
Copy link
Member

wing328 commented Sep 4, 2023

can you please merge the latest master into your branch and update the samples?

https://github.com/OpenAPITools/openapi-generator/actions/runs/6074641581/job/16479512246?pr=16500

@hightea hightea force-pushed the feat/java-microprofile-default-values branch from e25bdb3 to bf9625f Compare September 4, 2023 15:51
@hightea
Copy link
Contributor Author

hightea commented Sep 4, 2023

My bad, I had an unclean maven workspace.
However I've some difficulties to build the project behind my company proxy.
I'm going to run a full build on an other computer

@hightea hightea force-pushed the feat/java-microprofile-default-values branch from bf9625f to 242a1cd Compare September 4, 2023 16:45
@wing328
Copy link
Member

wing328 commented Sep 5, 2023

LGTM. Thanks for the fix.

@wing328 wing328 merged commit 4418b59 into OpenAPITools:master Sep 5, 2023
@wing328 wing328 added this to the 7.0.1 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants