[python][Feat] Deserialize error responses #17038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It matches black's behavior of having trailing commas now.
robertschweizer
commented
Nov 11, 2023
| {{#responses}} | ||
| {{^isWildcard}} | ||
| '{{code}}': {{#dataType}}"{{.}}"{{/dataType}}{{^dataType}}None{{/dataType}}, | ||
| {{/isWildcard}} | ||
| {{/responses}} | ||
| {{/returnType}} |
There was a problem hiding this comment.
What was the purpose of the {{#returnType}} condition here?
There was a problem hiding this comment.
This does not seem to affect the operation.
The {{#returnType}} simplifies the generated source code, but I don't think the simplification is necessary.
There was a problem hiding this comment.
Awesome, thanks for checking!
lwj5
pushed a commit
to lwj5/openapi-generator
that referenced
this pull request
Dec 5, 2023
* refactor: Clean up _response_types_map formatting It matches black's behavior of having trailing commas now. * test: Add test to reproduce OpenAPITools#16967 * fix: deserialize responses even if no returnType Closes OpenAPITools#16967 * refactor: Simplify ApiException subclasses * refactor: Move exception subtype choice to ApiException * feat: Deserialize error responses and add to exceptions * test: Add for error responses with model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds deserialized error responses to the raised HTTP exceptions, as I suggested in #16999
Closes #16967
See separate commits.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@wing328 @fa0311 @multani