-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalized mime type support #17285
Generalized mime type support #17285
Conversation
modules/openapi-generator/src/main/resources/typescript/model/ObjectSerializer.mustache
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript/model/ObjectSerializer.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript/model/ObjectSerializer.mustache
Show resolved
Hide resolved
@a-ignatov-parc thanks for your contribution! |
@macjohnny, thanks for the review! Just to manage expectations, I plan to make the suggested changes in the first part of next week 👍 |
@macjohnny, I apologize that addressing the feedback took longer than I initially anticipated. However, the PR is ready for the next round of review 👍 |
Hey, I just wanted to say thanks for contributing this, @a-ignatov-parc ! Just when we needed it, all we had to do was update the generator ❤️ |
@bodograumann, thank you for the feedback. It's great to know when your contribution has been useful to someone 🙂 |
Address #17282
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)