-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PowerShell] (multipart/form-data request) and proxy behaviour #18315
Merged
wing328
merged 15 commits into
OpenAPITools:master
from
condorcorde:client-multipart-support
Apr 7, 2024
Merged
[PowerShell] (multipart/form-data request) and proxy behaviour #18315
wing328
merged 15 commits into
OpenAPITools:master
from
condorcorde:client-multipart-support
Apr 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orde/openapi-generator into client-multipart-support
in modules/openapi-generator/src/main/resources/powershell/api_client.mustache, please replace tabs with spaces |
…orde/openapi-generator into client-multipart-support
appveyor (ps tests) passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/49563164 |
thanks for the PR. let's give it a try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes to
Invoke-ApiClient
inapi_client.mustache
:Invoke-RestMethod
: the-Form
parameter is taken directly from the function$FormParameters
variable without need of reprocessing. The simplicity of the replacement was preferred to a direct fix of the existing code, although the PowerShell 5 version ofInvoke-RestMethod
does not support the return of response headers and status ($null
values are returned instead).On PowerShell 5:
On PowerShell 7 (MacOS):
In the first case the call to
GetProxy()
may return the same URI as the target URI, but this generates an error when the protocol of the target URI is HTTPS.In the second case, the call to
GetProxy()
returns$null
instead, but this is incompatible with the presence of the parameter-ProxyUseDefaultCredentials
.Since both cases are equivalent to a direct request without proxy, the logic was modified to ignore them (lines 133-138).
Additional issues:
Invoke-ApiClient
if the parameterSkipCertificateCheck
is specified in PowerShell 5. This case should be handled in configuration.mustache.http://petstore.swagger.io:80/v2
. This generates extra errors because a redirect to HTTPS is performed, but the method of the new request is switched to GET. What is the rational for the choice to specify HTTP instead?PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@wing328
To close #17740