Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useSingleRequestParameter to typescript-nestjs generator #18476

Conversation

arivanandan
Copy link
Contributor

@arivanandan arivanandan commented Apr 24, 2024

Closes #18475

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@arivanandan arivanandan changed the title chore: add useSingleRequestParameter option Add useSingleRequestParameter to typescript-nestjs generator Apr 24, 2024
@arivanandan arivanandan marked this pull request as ready for review April 24, 2024 08:41
@arivanandan
Copy link
Contributor Author

I don't see any tests for options already. Since this is still experimental, is it ok to not have them?

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

@wing328
Copy link
Member

wing328 commented Apr 28, 2024

@arivanandan did you test the option locally? Does it work for you?

@wing328
Copy link
Member

wing328 commented Apr 30, 2024

let's give it a try

if it doesn't work, we can file another PR to fix it and add some tests.

@wing328 wing328 merged commit a4cf255 into OpenAPITools:master Apr 30, 2024
14 checks passed
@arivanandan arivanandan deleted the feat/typescript-nestjs-add-useSingleRequestParameter branch May 5, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][typescript-nestjs] Collect request parameters into a single object for service methods
2 participants