-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust-axum] Split up api trait per tag #18621
[rust-axum] Split up api trait per tag #18621
Conversation
please run |
Thanks for that, I had forgotten to run the rust specific samples and also caught an issue with one of the use statements, fixed in 7d6dbfc |
@linxGnu I have implemented your proposal of sorting and grouping traits to handle operations with multiple tags (see commit a896ed8) I'm not sure where the best place to implement it would be, however I have got it working currently in |
Thank you so much for great PR. I need sometime to review it. Hopefully will feedback to you around 11:00am Tue next week (Japan time) |
No worries, please take your time. I am not a Java developer, nor have I looked too deeply into the inner workings of this codebase so please be as particular as you would like regarding code styling etc, I am happy to make any adjustments you recommend. |
Totally agreed with this one. We can add more normalizer rules to cater more use cases if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output looks awesome to me! I just have some small comments, please fix them then LGTM @kalvinpearce
...penapi-generator/src/main/java/org/openapitools/codegen/languages/RustAxumServerCodegen.java
Outdated
Show resolved
Hide resolved
...penapi-generator/src/main/java/org/openapitools/codegen/languages/RustAxumServerCodegen.java
Outdated
Show resolved
Hide resolved
...penapi-generator/src/main/java/org/openapitools/codegen/languages/RustAxumServerCodegen.java
Outdated
Show resolved
Hide resolved
LGTM. Kindly cc @wing328 for help to review. |
The rust-axum generator creates a single
Api
trait that holds all operations. This PR instead creates a trait for each tag. This allows for more flexibility in how the api is implemented as one can use the openapi normalizer to modify the tags.cc @linxGnu
Fixes #18442.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)