[KOTLIN] Kotlinx serialization, use first party retrofit converter factory #18656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement #18593
What has changed:
Switched out the retrofit converter factory used for kotlinx_serialization in the kotlin generator with the new first party converter.
com.jakewharton.retrofit:retrofit2-kotlinx-serialization-converter
->com.squareup.retrofit2:converter-kotlinx-serialization
in modules/openapi-generator/src/main/resources/kotlin-client/build.gradle.mustachecom.jakewharton.retrofit2.converter.kotlinx.serialization.asConverterFactory
->retrofit2.converter.kotlinx.serialization.asConverterFactory
in modules/openapi-generator/src/main/resources/kotlin-client/libraries/jvm-retrofit2/infrastructure/ApiClient.kt.mustacheWhy was it changed:
Given that no further development is to be expected on the deprecated repository, and the fact that the repo was moved to a first party converter with no code changes between.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)Technical committee mentions
@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)