Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for freeform types #18722

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

aaronp
Copy link
Contributor

@aaronp aaronp commented May 21, 2024

This changes fixes routes which have freeform types. Previously they were just represented as "Object", and didn't have any default value.

The freeform schemas now are of type usjon.Value, with ujson.Null, to coincide with our cask ecosystem.

PR checklist

  • [x ] Read the contribution guidelines.
  • [ x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@aaronp
Copy link
Contributor Author

aaronp commented May 22, 2024

Howdy stranger! ;-)

@wing328 , please do let me know if I shouldn't be targeting you directly or I should at mention other people/groups.

I just wondered if you wouldn't mind having a look at this?

@wing328 wing328 merged commit 3a23261 into OpenAPITools:master May 23, 2024
15 checks passed
@wing328 wing328 added this to the 7.7.0 milestone Jun 30, 2024
@aaronp aaronp deleted the caskObject branch October 22, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants