Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long running test #18754

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented May 23, 2024

Depending on test exec environment, this test could linger around for ~8 minutes, b/c pinging test.com will not resolve and run into several timeouts.

Brings down CI time for Linux Suite from >10m to ~4m.

Before

Connections in this test time out with

java.net.ConnectException: Connection timed out: connect

grafik
grafik

After

Connection fails immediately with

java.net.ConnectException: Connection refused: connect

grafik
grafik

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Philzen Philzen force-pushed the fix-long-running-test branch 2 times, most recently from b20c55a to 8638013 Compare May 24, 2024 02:53
@Philzen
Copy link
Contributor Author

Philzen commented May 24, 2024

@wing328 Reviewers and contributors are going to like this :)

Unfortunately Windows and CircleCI checks are still far >10m, however this helps with time needed for local test suite execution.

Depending on test exec environment, this test could linger around
for ~8 minutes, b/c pinging test.com will not resolve and run into
seveal timeouts.
@Philzen Philzen force-pushed the fix-long-running-test branch from 8638013 to 5a17fdc Compare May 24, 2024 03:16
@wing328
Copy link
Member

wing328 commented May 25, 2024

nice. thanks for the PR.

for windows, we can improve that with another PR later.

@wing328 wing328 merged commit 746961d into OpenAPITools:master May 25, 2024
15 checks passed
@Philzen Philzen deleted the fix-long-running-test branch May 26, 2024 06:06
@Philzen
Copy link
Contributor Author

Philzen commented May 26, 2024

for windows, we can improve that with another PR later.

@wing328 i checked the actions' log, the test in question also fails quickly as expected there – however the total runtime of the windows actions is still high. Wondering how that could be optimized though.

@wing328 wing328 added this to the 7.7.0 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants