[PHP][php-ze-ph] Support for PHP 7.1+, Zend Expressive 3.2 and PathHander 0.4

[Articus]

PR checklist

• Read the contribution guidelines.
• Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
• Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
• Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@jebentier, @dkarlovi , @mandrean , @jfastnacht , @ackintosh , @ybelenko , @renepardon

Description of the PR

Update for php-ze-ph server generator - switch to PHP 7.1 for #1246 and corresponding dependency update.
And I also believe that current generated README.md for php-ze-ph complies with suggestions here.

[auto-labeler]

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

[ybelenko]

CircleCI says that there are uncomitted files in:
samples/server/petstore/php-ze-ph/src/App/Factory.php
samples/server/petstore/php-ze-ph/src/App/Middleware/
Please, regenerate your server and commit these files to fix CI job.

[ybelenko]

It seems to me as breaking change without fallback (PHP 7.1 and newer required) correct me if I'm wrong. Could you write any upgrade note for users? If it's already exists in generated README just copy it to current discussion.

[Articus]

CircleCI says that there are uncomitted files in:
samples/server/petstore/php-ze-ph/src/App/Factory.php
samples/server/petstore/php-ze-ph/src/App/Middleware/
Please, regenerate your server and commit these files to fix CI job.

Oops, sorry - forgot to delete samples folder before regenerating, so obsolete generated files were kept and new files were not added :[ Should be fixed now.

It seems to me as breaking change without fallback (PHP 7.1 and newer required)

Yes, that is correct. Updated generator creates server stub based on Zend Expressive 3.2 and PathHandler 0.4 . They both require PHP 7.1+ and are backward incompatible with their previous versions Zend Expressive 2.* and PathHandler 0.3 that were supported by php-ze-ph before. Hopefully it is not a huge issue though - this generator was meant to generate skeleton for new project, not ready-to-use library (like php-client for example).
So if you want ot migrate existing project, it is better to check migration notes for both libraries - here and here.

[ybelenko]

Sorry, for long delay. Tried to test locally. I had to install ext-yaml, but it's not mentioned in README.md. Then my installation failed with:

$ composer install
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.                                                                              
  Problem 1
    - zendframework/zend-httphandlerrunner 1.0.1 requires psr/http-message-implementation ^1.0 -> no matching package found.
    - articus/path-handler 0.4 requires zendframework/zend-expressive ^3.2 -> satisfiable by zendframework/zend-expressive[3.2.0, 3.2.1].
    - zendframework/zend-expressive 3.2.0 requires zendframework/zend-httphandlerrunner ^1.0.1 -> satisfiable by zendframework/zend-httphandlerrunner[1.0.1].
    - zendframework/zend-expressive 3.2.1 requires zendframework/zend-httphandlerrunner ^1.0.1 -> satisfiable by zendframework/zend-httphandlerrunner[1.0.1].
    - Installation request for articus/path-handler ^0.4 -> satisfiable by articus/path-handler[0.4].

My config:
OS: Windows 8.1
PHP 7.2.7 (cli) (built: Jun 19 2018 23:14:45)

Please, update composer.json to install missed dependencies.

[Articus]

Sorry, for long delay.

No problem, thanks for thorough review! Rushing with PR on Sunday evening was a terrible idea - made really silly and embarrassing mistakes :[
Delay allowed to cool off a bit and retest generated stub properly - added few more minor improvements. Hopefully should be ok to merge now :)

[ybelenko]

I've checked build locally and everything looks fine. All tested endpoints responded with 501 Not Implemented which is correct accordingly to README.md. I didn't check code with PHPCodeSniffer because this should be accomplished in next PRs.

Small notice, I'm embarrased, but I didn't know that 0.0.0.0 host need to be called as localhost. Maybe README.md should point that or suggest to use php -S localhost:8080 -t ./public instead.

[Articus]

Small notice, I'm embarrased, but I didn't know that 0.0.0.0 host need to be called as localhost. Maybe README.md should point that or suggest to use php -S localhost:8080 -t ./public instead.

I believe current variant php -S 0.0.0.0:8080 -t ./public is more versatile because it will start dev server on all network interfaces while php -S localhost:8080 -t ./public will start dev server only on loopback network interface that usually has IP 127.0.0.1. So if PHP CLI is installed on your machine both variants will work. But if PHP CLI is inside Docker container for example (like I usually do :) ), you will be able to reach only dev server started with php -S 0.0.0.0:8080 -t ./public.

[ybelenko]

Maybe README.md should point

@Articus I'm not asking you to change host, just describe it in the readme how user can reach API. I thought that build is broken when I cannot reach http://0.0.0.0:8080 in Google Chrome. This misunderstaning can cause a lot of issues.

[Articus]

Sorry, but I do believe that current information in README:

• start PHP development server: php -S 0.0.0.0:8080 -t ./public (or any other SAPI you prefer, just make sure that you configure webroot to ./public and rewrites to ./public/index.php)

is enough for any PHP developer capable of making complete application from stub because the way you access API at this point entirely depends on your development environment and your programming habits.

[ybelenko]

is enough for any PHP developer capable of making complete application

@Articus I've spend about 30-minutes to figured out why 0.0.0.0:8080 doesn't work in browser. Anyway, forget about it, maybe I'm just a low skill developer.

[wing328]

Tweet to promote the change: https://twitter.com/oas_generator/status/1090516974549909504