Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include licenseInfo for all the generated java code files #19273

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

turboFei
Copy link
Contributor

@turboFei turboFei commented Jul 31, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@turboFei turboFei changed the title Include license info for all the generated java code files Include licenseInfo for all the generated java code files Jul 31, 2024
@wing328
Copy link
Member

wing328 commented Aug 4, 2024

@turboFei
Copy link
Contributor Author

turboFei commented Aug 4, 2024

thanks, updated the sample.

@wing328
Copy link
Member

wing328 commented Aug 5, 2024

https://github.com/OpenAPITools/openapi-generator/actions/runs/10238086384/job/28345688715?pr=19273 fixed in the master so please ignore it for the time being

@turboFei
Copy link
Contributor Author

turboFei commented Aug 5, 2024

thanks, rebased the code and tried to re-generate

@wing328
Copy link
Member

wing328 commented Aug 14, 2024

thanks for the PR. let's give it a try

@wing328 wing328 merged commit 2bf2d9b into OpenAPITools:master Aug 14, 2024
96 checks passed
@turboFei turboFei deleted the include_license branch August 14, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants