Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] [Rust*] model-name-prefix causing invalid generated code #19922

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

linxGnu
Copy link
Contributor

@linxGnu linxGnu commented Oct 20, 2024

Kindly ping @wing328 to review.

This PR Fixes #19632

Integration test without problems:

./bin/generate-samples.sh bin/configs/manual/rust-axum-*
mvn integration-test -f samples/server/petstore/rust-axum/pom.xml

Noted: this PR update rust-axum samples properties to generate models with prefix.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@linxGnu linxGnu changed the title [BugFix] [Rust*] model-name-prefix causing invalid generated code] [BugFix] [Rust*] model-name-prefix causing invalid generated code Oct 20, 2024
@GeorgeFkd
Copy link
Contributor

Can you also generate the samples for the rest of the Rust implementations? As the change you did also affects all of the rust generators. Just do ./bin/generate-samples.sh ./bin/configs/*.yaml as indicated to be sure that all affected generators are properly generated and pass the checks.

@linxGnu
Copy link
Contributor Author

linxGnu commented Oct 21, 2024

@GeorgeFkd
Ran ./bin/generate-samples.sh ./bin/configs/*.yaml -> no changes -> safe

@linxGnu
Copy link
Contributor Author

linxGnu commented Oct 21, 2024

Added an sample for reqwest with model-name-prefix. PTAL @wing328
cc @GeorgeFkd as well to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants