Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-fetch]: Fix package.json main. #3739

Closed

Conversation

jgiles
Copy link
Contributor

@jgiles jgiles commented Aug 23, 2019

The "main" and "typings" files are generated under "./dist/src", not
"./dist".

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Update the "main" and "typings" properties in package.json to match the files actually generated.

The "main" and "typings" files are generated under "./dist/src", not
"./dist".
@auto-labeler
Copy link

auto-labeler bot commented Aug 23, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@jgiles
Copy link
Contributor Author

jgiles commented Aug 23, 2019

@macjohnny unrelated to the requests stuff, but I noticed that package.json appears inconsistent with actual generated files locations. I think these were missed in the refactoring that pulled things under the src tree.

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07)

@macjohnny
Copy link
Member

this change should not be necessary, see #3694 (comment)

@macjohnny
Copy link
Member

@jgiles can you please post the commands you performed before you ended up with files in /dist/src?
cc @JFCote

@jgiles
Copy link
Contributor Author

jgiles commented Aug 23, 2019

Yeah, it turns out the location change was the result of adding "composite": true to the tsconfig compiler options. That setting is useful for building this generated code as part of a larger project, but I guess it can't be set without adjusting a couple other things.

Possibly a codegen option feature, but out-of-scope for the moment.

@jgiles jgiles closed this Aug 23, 2019
@jgiles
Copy link
Contributor Author

jgiles commented Aug 23, 2019

For the record @macjohnny the fix for using "composite": true is to also set "rootDir": "src".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants