fix: prevent ClassCastException when handling options of (issue #4468) #4495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
janweinschenker
changed the title
janweinschenker
changed the title
|
@janweinschenker thanks for the fix, which looks good to me. |
wing328
reviewed
Nov 17, 2019
| if (booleanValue instanceof Boolean) { | ||
| result = (Boolean) booleanValue; | ||
| } else if (booleanValue instanceof String) { | ||
| result = Boolean.parseBoolean((String) booleanValue); | ||
| } |
There was a problem hiding this comment.
@janweinschenker I'll add an else clause to throw a runtime exception here.
jimschubert
added a commit
to jimschubert/openapi-generator
that referenced
this pull request
Nov 17, 2019
…ulti-level-model-hierarchy * origin/master: minor fix to CI failure feat(dart-dio): correctly handle Map<String, Object>, List<Object> using JsonObject (OpenAPITools#4401) [OCAML] Fixes cloud.drone.io ocaml-test (OpenAPITools#4501) [elm] Add support for oneOf (OpenAPITools#4434) [BUG] [Java] Client resttemplate and webclient. Form Params are badly added when they are lists (OpenAPITools#4461) fix: prevent ClassCastException when handling options of (issue OpenAPITools#4468) (OpenAPITools#4495) Fixes Python client Configuration class so each instance uses its own dicts (OpenAPITools#4485)
|
@janweinschenker thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4468 - Prevent ClassCastException when Dealing with config options of type boolean in both openapi-generator-cli and openapi-generator-maven
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.