Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port date parsing fix from swagger-codegen #4703

Closed
wants to merge 1 commit into from

Conversation

tovkal
Copy link

@tovkal tovkal commented Dec 4, 2019

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Description

This is a fix that was originally merged into the swagger-codegen repo (original PR). A PR to bring the same fix to Swift 4 has being done to the openapi-generator repo.

@4brunu
Copy link
Contributor

4brunu commented Dec 5, 2019

@tovkal Thanks for this PR. We have other two PR open related to dates.
Once I have some time, I will try to look into this 🙂

@4brunu
Copy link
Contributor

4brunu commented Dec 10, 2019

@tovkal Thanks for your contribution.
We are working on trying to merge #3365 that will allow to define a custom JSONDecoder and a custom dateDecodingStrategy.
I think this is more flexible and will allow everyone to specify the behaviour that they want.
What do you think?

@wing328
Copy link
Member

wing328 commented Jan 2, 2020

The fix is available in the newly-added swift5 generator so closing this one instead.

@wing328 wing328 closed this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants