typescript-fetch: Fix compatibility with noImplicitAny TS rule #4711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please run |
macjohnny
changed the title
|
done. |
macjohnny
reviewed
Dec 6, 2019
modules/openapi-generator/src/main/resources/typescript-fetch/runtime.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-fetch/runtime.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-fetch/runtime.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-fetch/runtime.mustache
Outdated
Show resolved
Hide resolved
macjohnny
changed the title
…runtime.mustache Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
…runtime.mustache Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
…runtime.mustache Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
…runtime.mustache Co-Authored-By: Esteban Gehring <esteban.gehring@gmail.com>
|
please re-generate the samples with |
|
For some reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR
runtime.ts file generated by typescript-fetch template doesn't meet the needs of Typescript rule "noImplicitAny" that requires that any function should return an object with its type.
With the current version, the user gets a compile error and it's not possible to fix this error by removing the TS rule. In CRA (Create React Apps and react-script) this rule is kind of "hardcoded" in tsconfig.json. The rules are overridden each time a compilation is raised.
How it solve the issue ?
Just by adding the correct return types. It doesn't break anything in the current code, it just ensures that correct types will be returned.