Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Native] Add asyncNative option #4721

Merged
merged 6 commits into from
May 3, 2020
Merged

[Java][Native] Add asyncNative option #4721

merged 6 commits into from
May 3, 2020

Conversation

UkonnRa
Copy link
Contributor

@UkonnRa UkonnRa commented Dec 6, 2019

Related Issue

#4715

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@UkonnRa
Copy link
Contributor Author

UkonnRa commented Dec 7, 2019

@lwlee2608 Add the support of async native Java Client

@wing328
Copy link
Member

wing328 commented Dec 12, 2019

cc @bbdouglas as it's related to Java 11 Native client.

@wing328
Copy link
Member

wing328 commented Dec 19, 2019

Instead of adding another option. What about adding an "Async" version of the function similar to what we've done in other Java client libraries (e.g. okhttp-gson)? e.g. https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/Java/libraries/okhttp-gson/api.mustache#L283

e.g. addPet => addPetAsync (and addPet simply calls addPetAsync and wait for the completion)

@joerg-wille
Copy link

@UkonnRa What is the status of the native async patch? Your changes look good.

@wing328
Copy link
Member

wing328 commented May 3, 2020

UPDATE: I've resolved the merge conflicts, update samples and include the native async petstore client in the drone.io CI tests.

@wing328 wing328 added this to the 4.3.1 milestone May 3, 2020
@wing328
Copy link
Member

wing328 commented May 3, 2020

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

@wing328
Copy link
Member

wing328 commented May 3, 2020

CircleCI failure due to outdated doc/samples. Will fix it in a separate commit after merging into master.

@wing328 wing328 merged commit f4fa00f into OpenAPITools:master May 3, 2020
@wing328 wing328 changed the title Add async native Java Client [Java][Native] Add asyncNative option May 3, 2020
@wing328
Copy link
Member

wing328 commented May 3, 2020

@UkonnRa thanks for the PR, which has been merged into master.

When you're free, I wonder if you can PM me via Slack (https://github.com/OpenAPITools/openapi-generator.git) for a quick chat (IM). Thank you.

michaelpro1 pushed a commit to michaelpro1/openapi-generator that referenced this pull request May 7, 2020
* Add async native Java Client

* UPDATE: Reformat the samples

* test java native async in drone.io

* update test count

Co-authored-by: William Cheng <wing328hk@gmail.com>
MikailBag pushed a commit to MikailBag/openapi-generator that referenced this pull request May 31, 2020
* Add async native Java Client

* UPDATE: Reformat the samples

* test java native async in drone.io

* update test count

Co-authored-by: William Cheng <wing328hk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants