Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added named params to typescript-axios #5549

Closed
wants to merge 1 commit into from
Closed

added named params to typescript-axios #5549

wants to merge 1 commit into from

Conversation

facundomedica
Copy link
Contributor

This enables the use of an object as a parameter thus avoiding getting the parameters scrambled during a re-generation of the client.

Ref: #5385

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @nicokoenig @topce @akehir @petejohansonxo @amakhrov

@macjohnny
Copy link
Member

Thanks for your contribution
In order to avoid backwards incompatible changes, please add an option similar to #4479

@questionablequestion
Copy link

@facundomedica any update on this? It would be amazing if we could get this released as I need this as well.

Thanks!

@facundomedica
Copy link
Contributor Author

Sorry guys! I've been quite busy, I don't know when I will be able to get back to this. If anyone wants to jump in and finish it up, it would be nice! If not, please be patient, I hope I can get back to this someday soon

@michaeldabbott
Copy link

I'm happy to take over this for my first contribution to this project.

Can you point me in the right direction to generating a sample typescript-axios typings for me to just double check if anything needs changing?

@macjohnny
Copy link
Member

@abbottm-go you can generate the samples with https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-axios-petstore-with-npm-version-and-separate-models-and-api.sh

make sure to run mvn clean package first

@michaeldabbott
Copy link

@abbottm-go you can generate the samples with https://github.com/OpenAPITools/openapi-generator/blob/master/bin/typescript-axios-petstore-with-npm-version-and-separate-models-and-api.sh

make sure to run mvn clean package first

Awesome thank you

@codeserk
Copy link
Contributor

FYI, I've opened a follow-up PR, hopefully we can have this functionality in this generator soon 🤞

@macjohnny
Copy link
Member

closing in favor of #6288

@macjohnny macjohnny closed this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants