Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php] Set required PHP 7.1 in code comments and readme #6188

Merged
merged 8 commits into from
May 8, 2020

Conversation

ybelenko
Copy link
Contributor

@ybelenko ybelenko commented May 6, 2020

There was PHP 5 appearances left in some places.
Travis-CI config has been slightly updated.
PHP_CodeSniffer has been removed in favor of PHP-CS-Fixer.

Related issue #1246

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @renepardon

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328
Copy link
Member

wing328 commented May 7, 2020

Can you please update the samples under samples/openapi3 as well?

	modified:   samples/openapi3/client/petstore/php/OpenAPIClient-php/.travis.yml
 
	modified:   samples/openapi3/client/petstore/php/OpenAPIClient-php/README.md
 
	modified:   samples/openapi3/client/petstore/php/OpenAPIClient-php/composer.json
 
	modified:   samples/openapi3/client/petstore/php/OpenAPIClient-php/lib/Api/AnotherFakeApi.php
 
	modified:   samples/openapi3/client/petstore/php/OpenAPIClient-php/lib/Api/DefaultApi.ph

Please also merge the latest master into this branch as the Circle CI failure has been fixed in the master.

@ybelenko ybelenko force-pushed the 1246_php_client branch from 0c8ddb5 to f44ece9 Compare May 7, 2020 14:35
@ybelenko ybelenko force-pushed the 1246_php_client branch from f44ece9 to bb8e001 Compare May 7, 2020 17:36
@wing328 wing328 added this to the 5.0.0 milestone May 8, 2020
@wing328 wing328 merged commit 8c6236b into OpenAPITools:master May 8, 2020
@ybelenko ybelenko deleted the 1246_php_client branch May 8, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants