Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling spaces in example command #6482

Merged
merged 1 commit into from
May 30, 2020

Conversation

mik-laj
Copy link
Contributor

@mik-laj mik-laj commented May 29, 2020

When you run this command in a directory that contains spaces, it will not execute correctly. Sample result.

docker: invalid reference format: repository name must be lowercase.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 added this to the 5.0.0 milestone May 30, 2020
@wing328 wing328 merged commit 40a7e53 into OpenAPITools:master May 30, 2020
@mik-laj
Copy link
Contributor Author

mik-laj commented May 30, 2020

@wing328 Thank you. You are a fantastic man. Keep it up.

@wing328
Copy link
Member

wing328 commented May 30, 2020

@mik-laj thanks for the kind words and the PR. Have a nice weekend.

@mik-laj
Copy link
Contributor Author

mik-laj commented May 30, 2020

I, along with the Apache Airflow community, are considering using this tool to generate Apache Airflow API clients. If you are interested, then our last discussion is available here.
https://lists.apache.org/thread.html/r88f5f57b4586f75eda382ce2c7309bd32b58cd9cfa1b01f681b6c8d1%40%3Cdev.airflow.apache.org%3E

Apache Airflow is one of the 5 most active projects of the Apache foundation.

jimschubert added a commit that referenced this pull request May 30, 2020
* master: (36 commits)
  Improve handling spaces in example command (#6482)
  fix maven plugin snapshot version
  comment out erlang server test (#6499)
  Migrate Perl samples to use OAS v3 spec (#6490)
  [core] Refactor templating management (#6357)
  migrate apex samples to use oas3 spec (#6488)
  add new file in php-symfony sample
  [PS] Refactor the http signing auth with ecdsa support (#6397)
  [Rust Server] Hyper 0.13 + Async/Await support (#6244)
  [Rust] set supportAsync to true as the default (#6480)
  [php-symfony] Set required PHP version ^7.1.3 (#6181)
  update doc
  [csharp] Rename netstandard to netstandard1.3 (#6460)
  feat: support deprecated parameters for typescript-axios generator (#6475)
  [REQ][typescript-axios] useSingleRequestParameter should mark parameter optional if all properties are optional (#6477)
  better struct alias in rust (#6470)
  Migrate Go server samples to OAS 3 only (#6471)
  [Rust][reqwest] add async support (#6464)
  [codegen][python-experimental] Composed schema with additionalProperties  (#6290)
  [Java] Decommission Retrofit 1.x support (#6447)
  ...
@wing328
Copy link
Member

wing328 commented Jun 1, 2020

Glad to hear. Many open-source projects have leveraged OpenAPI Generator to generate SDKs. Some of these projects can be found in https://openapi-generator.tech/users

Please feel free to add Apache Airflow to the list after you guys decide to use it to generate SDKs for Apache Airflow.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants