Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][cli] Moving ensures script to config-based batch generation of samples #6509

Merged
merged 40 commits into from
Jun 9, 2020
Merged
Show file tree
Hide file tree
Changes from 35 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
ac4eb20
Ensure CLI-level generator settings are available in additional prope…
jimschubert May 31, 2020
198b036
Initial conversion to yaml configs
jimschubert May 31, 2020
bc8c6bc
Add "other" configs not in ensure-up-to-date
jimschubert May 31, 2020
b7c3911
Add other/openapi3 files
jimschubert May 31, 2020
ad328b2
Cleanup all generation scripts
jimschubert May 31, 2020
9b73136
Clean up: add missed configs and fix some openapi 3 diffs
jimschubert Jun 1, 2020
cc8ee47
Move generate-samples script, error on batch failures
jimschubert Jun 1, 2020
0686c49
Temporarily disable elm which requires skip validation of spec
jimschubert Jun 1, 2020
7b5c203
CI updates (todo: run all generators through appveyor or move to gith…
jimschubert Jun 1, 2020
838dea5
Add success count to batch generation command output
jimschubert Jun 1, 2020
957ab0a
[samples] Regenerate
jimschubert Jun 2, 2020
41fbed7
Remove bin/windows
jimschubert Jun 2, 2020
68bbb4a
Generate swift5 samples in bitrise
jimschubert Jun 2, 2020
1aa03d4
Merge branch 'master' into ensures
jimschubert Jun 2, 2020
fb88119
Expand user input glob pattern
jimschubert Jun 2, 2020
582f814
Regenerate samples
jimschubert Jun 2, 2020
898d28c
Update PR template
jimschubert Jun 2, 2020
886ed4c
Support config based generateAliasAsModel
jimschubert Jun 2, 2020
bef688c
[samples] Regenerate
jimschubert Jun 2, 2020
8727e8c
[rust] Generate as alias for all samples configs
jimschubert Jun 3, 2020
62e9c1a
[csharp] Move test staged file changes to in-directory
jimschubert Jun 3, 2020
b246774
Include "live" test files and ignore test cache files from samples.ci
jimschubert Jun 3, 2020
e2790ef
Remove concept of samples.ci staging
jimschubert Jun 3, 2020
9aa5675
Merge branch 'master' into ensures
jimschubert Jun 3, 2020
305e52f
Re-add meta generator scripts
jimschubert Jun 3, 2020
818e141
Modify ensure-up-to-date to log stdout, so script does not look like …
jimschubert Jun 3, 2020
679a127
[csharp] Regenerate sample
jimschubert Jun 3, 2020
a76b991
Set generateAliasAsModel CodegenConfigurator#toContext
jimschubert Jun 3, 2020
6319879
[rust] Regenerate samples
jimschubert Jun 3, 2020
35ebf9b
Re-enable elm
jimschubert Jun 4, 2020
549ca38
Merge branch 'master' into ensures
jimschubert Jun 4, 2020
1ee614f
[java] Support OffsetDateTime example, fail ensures script on any gen…
jimschubert Jun 4, 2020
4e5e81b
[samples] Regenerate
jimschubert Jun 4, 2020
9ddc45c
Merge branch 'master' into ensures
jimschubert Jun 6, 2020
2741747
Fix jersey2-java8 ignore file
jimschubert Jun 6, 2020
68763d4
Fix elm spec validation
jimschubert Jun 6, 2020
97e84eb
Force UTC in sample generation to avoid timezone conflicts during gen…
jimschubert Jun 6, 2020
fea207a
Merge branch 'master' into ensures
jimschubert Jun 6, 2020
63ba557
Merge branch 'master' into ensures
wing328 Jun 8, 2020
080581b
Merge remote-tracking branch 'origin/master' into ensures
wing328 Jun 9, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
### PR checklist

- [ ] Read the [contribution guidelines](https://github.com/openapitools/openapi-generator/blob/master/CONTRIBUTING.md).
- [ ] If contributing template-only or documentation-only changes which will change sample output, [build the project](https://github.com/OpenAPITools/openapi-generator#14---build-projects) before.
- [ ] Run the shell script(s) under `./bin/` (or Windows batch scripts under`.\bin\windows`) to update Petstore samples related to your fix. This is important, as CI jobs will verify _all_ generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run `./bin/{LANG}-petstore.sh`, `./bin/openapi3/{LANG}-petstore.sh` if updating the code or mustache templates for a language (`{LANG}`) (e.g. php, ruby, python, etc).
- [ ] If contributing template-only or documentation-only changes which will change sample output, [build the project](https://github.com/OpenAPITools/openapi-generator#14---build-projects) beforehand.
- [ ] Run the shell script `./bin/generate-samples.sh`to update all Petstore samples related to your fix. This is important, as CI jobs will verify _all_ generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example `./bin/generate-samples.sh bin/config/java*`.
- [ ] File the PR against the [correct branch](https://github.com/OpenAPITools/openapi-generator/wiki/Git-Branches): `master`, `4.3.x`, `5.0.x`. Default: `master`.
- [ ] Copy the [technical committee](https://github.com/openapitools/openapi-generator/#62---openapi-generator-technical-committee) to review the pull request if your PR is targeting a particular programming language.
4 changes: 2 additions & 2 deletions CI/.drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@ steps:
# generate test scripts
- /bin/bash bin/tests/run-all-test
# generate all petstore samples (client, servers, doc)
spacether marked this conversation as resolved.
Show resolved Hide resolved
- /bin/bash bin/run-all-petstore
- /bin/bash bin/generate-samples.sh
# generate all petstore samples (openapi3)
- /bin/bash bin/openapi3/run-all-petstore
- /bin/bash bin/generate-samples.sh bin/configs/other/*.yaml
spacether marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion CI/bitrise.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ workflows:

set -e

sh bin/swift5-all.sh
sh bin/generate-samples.sh bin/configs/swift5-*.yaml
spacether marked this conversation as resolved.
Show resolved Hide resolved
- script@1.1.5:
title: Run Swift5 tests
inputs:
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Binary file not shown.
122 changes: 0 additions & 122 deletions CI/samples.ci/client/petstore/java/jersey2-java6/build.gradle

This file was deleted.

This file was deleted.

Loading