Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a missing return in the C client sslConfig_create function. #7217

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

brendandburns
Copy link
Contributor

Fixes a missing return in the sslConfig_create function in the C client templates.

cc @zhemant @ityuhui @michelealbano

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 554747d into OpenAPITools:master Aug 15, 2020
@wing328 wing328 added this to the 5.0.0 milestone Aug 15, 2020
@ityuhui
Copy link
Contributor

ityuhui commented Aug 15, 2020

It's a very important patch. Thank you @brendandburns and @wing328

@wing328
Copy link
Member

wing328 commented Aug 15, 2020

I used Clang Static Analyzer to detect potential issues with the C Petstore client and it's able to detect issues fixed by this PR.

For the full report, please refer to #7221 and we'll review and address those issues with separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants