Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[online] use Files.createTempFile to address security concerns #8788

Merged
merged 2 commits into from
Feb 23, 2021
Merged

[online] use Files.createTempFile to address security concerns #8788

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be64b6f
use Files.createTempFile to address security concerns
wing328 Feb 22, 2021
0c38e6d
Update modules/openapi-generator-online/src/main/java/org/openapitool…
wing328 Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...api-generator-online/src/main/java/org/openapitools/codegen/online/service/Generator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.springframework.web.server.ResponseStatusException;

import java.io.File;
import java.nio.file.Files;
import java.util.ArrayList;
import java.util.LinkedHashMap;
import java.util.List;
Expand Down Expand Up @@ -181,9 +182,7 @@ private static String generate(String language, GeneratorInput opts, Type type)

private static File getTmpFolder() {
try {
File outputFolder = File.createTempFile("codegen-", "-tmp");
outputFolder.delete();
outputFolder.mkdir();
File outputFolder = Files.createTempDirectory("codegen-tmp").toFile();
outputFolder.deleteOnExit();
return outputFolder;
} catch (Exception e) {
Expand Down