Use Kotlin nullable operator for nullable properties #9799
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous check of isReadOnly was not applicable to whether a value should be null or not. As far as I can tell that is more to do with a RESTful design principal than to do with whether the code should present a models values as nullable.
Initially I thought the
?
should be removed if the value is set to required = true but it is important to note that required != non-null, i.e. the field can be required but the value might still be null (if nullable = true).The default null value will no longer be supplied if the value is not nullable.
Also removed escaping of default string values (this would cause any default string value to be written to the file as
val test = "value"
instead ofval test = "value"
.This would clearly be a breaking change so have set it to a major release branch. Please let me know if you think it could actually go into a minor release.
[kotlin committee]
@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x