Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python client - fixes boolean enum use case #9926

Merged
merged 4 commits into from
Jul 10, 2021

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Jul 9, 2021

Python client - fixes boolean enum use case
Before this PR, the allowed values for booleans were incorrectly cased strings "true" when it should have been True
After this PR they are correctly cased python values like True/False

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether modified the milestones: 6.0.0, 5.3.0 Jul 10, 2021
@spacether spacether merged commit 11515da into OpenAPITools:master Jul 10, 2021
@spacether spacether deleted the adds_bool_enum_to_python branch July 10, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant