-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for changing intensity of LEDs #23
Conversation
@@ -26,25 +26,26 @@ | |||
static void columnCallback(GPTDriver* driver); | |||
static void animationCallback(GPTDriver* driver); | |||
static void executeMsg(msg_t msg); | |||
static void switchProfile(void); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed unused function
LINE_LED_COL_7, | ||
LINE_LED_COL_8, | ||
LINE_LED_COL_9, | ||
LINE_LED_COL_1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing whitespace cleanup
@@ -79,24 +80,29 @@ ioline_t ledRows[NUM_ROW * 4] = { | |||
|
|||
#define ANIMATION_TIMER_FREQUENCY 60 | |||
|
|||
#define KEY_COUNT 70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw a TODO for defining this, so I did.
/* | ||
* Set profile and execute it | ||
*/ | ||
void setProfile(){ | ||
void setProfile() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reformatted these and below functions
please rebase your commit. Thanks |
@Codetector1374, just rebased. Thanks! |
Thanks. Please try to keep style changes a separate PR from content changes. It is kind of hard to read the diff this way. But good work. |
I implemented the intensity functionality by right shifting each component of RGB color.
Intensities range range from 0 to 3. Default intensity is 0 which corresponds to the original color.
Corresponding PR in the main repo is here