Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #154: Remove ID from Video screen, add chaptername and courseNa… #161

Merged
merged 7 commits into from
Oct 27, 2019

Conversation

inspire99
Copy link
Contributor

@inspire99 inspire99 commented Oct 27, 2019

Description

Remove ID from Video screen, add chaptername and courseName instead

Fixes #154 and Fixes #51

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

videoupdatecomponent.spec.ts updated
VideoResourceIT updated.
manually tested

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • New and existing unit tests pass locally with my changes

…and courseName instead

Fixes OpenArchitex#154: Remove ID from Video screen, add chaptername and courseName instead
…and courseName instead

Fixes OpenArchitex#154: Remove ID from Video screen, add chaptername and courseName instead
…ments entity screen

Fixes OpenArchitex#51 : Add video name instead of video id in the comments entity screen

Referred videoName in comments screen
Fixed failing testcases - CommentResourceIT
Fixed failing testcases - CommentResourceIT
@inspire99
Copy link
Contributor Author

This pull request also fixes #51

Best Regards
Ganesh

@SudharakaP SudharakaP merged commit 5d5a409 into OpenArchitex:develop Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants