Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using rocky linux instead of centos in github ci workflow #2806

Closed
AlexStocks opened this issue Jul 15, 2024 · 1 comment · Fixed by #2823
Closed

using rocky linux instead of centos in github ci workflow #2806

AlexStocks opened this issue Jul 15, 2024 · 1 comment · Fixed by #2823
Labels
☢️ Bug Something isn't working

Comments

@AlexStocks
Copy link
Collaborator

Is this a regression?

Yes

Description

image

github ci workflow always failed on centos platform.

somebody suggests we use centos stream or rocky linux instead.

Considering the steady of OS, we should use rocky linux as our platform instead of centos.

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

No response

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response

@AlexStocks AlexStocks added the ☢️ Bug Something isn't working label Jul 15, 2024
@lqxhub
Copy link
Collaborator

lqxhub commented Jul 19, 2024

pika/CMakeLists.txt

Lines 162 to 170 in 6c0e0d4

if(${OS_VERSION} MATCHES "CentOS")
set(GTEST_LIBRARY ${INSTALL_LIBDIR_64}/libgtest.a)
set(GTEST_MAIN_LIBRARY ${INSTALL_LIBDIR_64}/libgtest_main.a)
set(GMOCK_LIBRARY ${INSTALL_LIBDIR_64}/libgmock.a)
else()
set(GTEST_LIBRARY ${INSTALL_LIBDIR}/libgtest.a)
set(GTEST_MAIN_LIBRARY ${INSTALL_LIBDIR}/libgtest_main.a)
set(GMOCK_LIBRARY ${INSTALL_LIBDIR}/libgmock.a)
endif()

cmake 中很多和 centos 相关的判断, 这个应该需要同步修改

@luky116 luky116 closed this as completed Jul 26, 2024
AlexStocks pushed a commit that referenced this issue Jul 29, 2024
* add a new test env (rocky linux) in github ci.
chejinge pushed a commit that referenced this issue Jul 31, 2024
* add a new test env (rocky linux) in github ci.
cheniujh pushed a commit to cheniujh/pika that referenced this issue Sep 24, 2024
cheniujh pushed a commit to cheniujh/pika that referenced this issue Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☢️ Bug Something isn't working
Projects
None yet
3 participants