Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Revise the value check for max-rsync-parallel-num to prevent a core dump when it is set to a value greater than 4 #2595

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

cheniujh
Copy link
Collaborator

fix #2594
Revise the value check for max-rsync-parallel-num to prevent a core dump when it is set to a value greater than 4

@cheniujh cheniujh changed the title Revise the value check for max-rsync-parallel-num to prevent a core dump when it is set to a value greater than 4 fix:Revise the value check for max-rsync-parallel-num to prevent a core dump when it is set to a value greater than 4 Apr 15, 2024
@github-actions github-actions bot added the ☢️ Bug Something isn't working label Apr 15, 2024
@AlexStocks AlexStocks merged commit b58beb0 into OpenAtomFoundation:unstable Apr 15, 2024
14 checks passed
chenbt-hz pushed a commit to chenbt-hz/pika that referenced this pull request Apr 15, 2024
…re dump when it is set to a value greater than 4 (OpenAtomFoundation#2595)

* revised value check of max-rsync-parallel-num to avoid core dump when it's value greater than 4

* avoid fixed num, use kMaxRsyncParallelNum instead

* use kMaxRsyncParallelNum to replace another two fixed num 4

---------

Co-authored-by: cjh <1271435567@qq.com>
chejinge pushed a commit that referenced this pull request Apr 16, 2024
…re dump when it is set to a value greater than 4 (#2595)

* revised value check of max-rsync-parallel-num to avoid core dump when it's value greater than 4

* avoid fixed num, use kMaxRsyncParallelNum instead

* use kMaxRsyncParallelNum to replace another two fixed num 4

---------

Co-authored-by: cjh <1271435567@qq.com>
chenbt-hz pushed a commit to chenbt-hz/pika that referenced this pull request Apr 19, 2024
…re dump when it is set to a value greater than 4 (OpenAtomFoundation#2595)

* revised value check of max-rsync-parallel-num to avoid core dump when it's value greater than 4

* avoid fixed num, use kMaxRsyncParallelNum instead

* use kMaxRsyncParallelNum to replace another two fixed num 4

---------

Co-authored-by: cjh <1271435567@qq.com>
chejinge pushed a commit that referenced this pull request May 15, 2024
…re dump when it is set to a value greater than 4 (#2595)

* revised value check of max-rsync-parallel-num to avoid core dump when it's value greater than 4

* avoid fixed num, use kMaxRsyncParallelNum instead

* use kMaxRsyncParallelNum to replace another two fixed num 4

---------

Co-authored-by: cjh <1271435567@qq.com>
chejinge pushed a commit that referenced this pull request May 15, 2024
…ent a core dump when it is set to a value greater than 4 (#2595)"

This reverts commit f6d72f2.
chejinge pushed a commit that referenced this pull request May 15, 2024
…re dump when it is set to a value greater than 4 (#2595)

* revised value check of max-rsync-parallel-num to avoid core dump when it's value greater than 4

* avoid fixed num, use kMaxRsyncParallelNum instead

* use kMaxRsyncParallelNum to replace another two fixed num 4

---------

Co-authored-by: cjh <1271435567@qq.com>
 Author:    cheniujh <41671101+cheniujh@users.noreply.github.com>
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
…re dump when it is set to a value greater than 4 (OpenAtomFoundation#2595)

* revised value check of max-rsync-parallel-num to avoid core dump when it's value greater than 4

* avoid fixed num, use kMaxRsyncParallelNum instead

* use kMaxRsyncParallelNum to replace another two fixed num 4

---------

Co-authored-by: cjh <1271435567@qq.com>
@coderabbitai coderabbitai bot mentioned this pull request Jun 27, 2024
cheniujh added a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
…re dump when it is set to a value greater than 4 (OpenAtomFoundation#2595)

* revised value check of max-rsync-parallel-num to avoid core dump when it's value greater than 4

* avoid fixed num, use kMaxRsyncParallelNum instead

* use kMaxRsyncParallelNum to replace another two fixed num 4

---------

Co-authored-by: cjh <1271435567@qq.com>
cheniujh added a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
…re dump when it is set to a value greater than 4 (OpenAtomFoundation#2595)

* revised value check of max-rsync-parallel-num to avoid core dump when it's value greater than 4

* avoid fixed num, use kMaxRsyncParallelNum instead

* use kMaxRsyncParallelNum to replace another two fixed num 4

---------

Co-authored-by: cjh <1271435567@qq.com>
cheniujh added a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
…re dump when it is set to a value greater than 4 (OpenAtomFoundation#2595)

* revised value check of max-rsync-parallel-num to avoid core dump when it's value greater than 4

* avoid fixed num, use kMaxRsyncParallelNum instead

* use kMaxRsyncParallelNum to replace another two fixed num 4

---------

Co-authored-by: cjh <1271435567@qq.com>
cheniujh pushed a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
…ent a core dump when it is set to a value greater than 4 (OpenAtomFoundation#2595)"

This reverts commit 2a0df99.
cheniujh added a commit to cheniujh/pika that referenced this pull request Sep 24, 2024
…re dump when it is set to a value greater than 4 (OpenAtomFoundation#2595)

* revised value check of max-rsync-parallel-num to avoid core dump when it's value greater than 4

* avoid fixed num, use kMaxRsyncParallelNum instead

* use kMaxRsyncParallelNum to replace another two fixed num 4

---------

Co-authored-by: cjh <1271435567@qq.com>
 Author:    cheniujh <41671101+cheniujh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.5.4 4.0.0 ☢️ Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slave Node will coredump if if conf item "max-rsync-parallel-num" is greater than 4
5 participants