fix:Add the output data of command 'info keyspace 0' to the output of com… #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaoLiang2333
changed the title
XiaoLiang2333
changed the title
chejinge
reviewed
Apr 28, 2024
src/pika_admin.cc
Outdated
| tmp_stream << "# Use \"info keyspace 1\" do async statistics" | ||
| << "\r\n"; | ||
| } | ||
|
|
||
| **/ |
chejinge
reviewed
Apr 28, 2024
src/pika_admin.cc
Outdated
| } else { | ||
| tmp_stream << "# Use \"info keyspace 1\" to do async statistics\r\n"; // Command=>"info" | ||
| } | ||
| /**if (argv_.size() == 3){ // command => `info keyspace 1` or `info all` |
Remove obsolete code
chejinge
approved these changes
Apr 28, 2024
AlexStocks
approved these changes
Apr 28, 2024
Mixficsol
reviewed
Apr 28, 2024
src/pika_admin.cc
Outdated
| @@ -1194,15 +1196,19 @@ void InfoCmd::InfoKeyspace(std::string& info) { | |||
| std::stringstream tmp_stream; | |||
| tmp_stream << "# Keyspace" | |||
| << "\r\n"; | |||
| if (argv_.size()> 1 && strcasecmp(argv_[1].data(), kAllSection.data()) == 0) { | |||
There was a problem hiding this comment.
if (argv_.size() > 1 && strcasecmp(argv_[1].data(), kAllSection.data()) == 0) {
tmp_stream << "# Start async statistics\r\n";
} else if (argv_.size() == 3 && strcasecmp(argv_[1].data(), kKeyspaceSection.data()) == 0) {
tmp_stream << "# Start async statistics\r\n";
} else {
tmp_stream << "# Use \"info keyspace 1\" to do async statistics\r\n";
}这样写是不是更好一些
There was a problem hiding this comment.
是的,我过于执着分支了,你的代码健壮性和清晰度都更好
Mixficsol
approved these changes
Apr 29, 2024
chejinge
pushed a commit
that referenced
this pull request
May 15, 2024
… com… (#2603) * Add the output data of command 'info keyspace 1' to the output of command 'info all'
chenbt-hz
pushed a commit
to chenbt-hz/pika
that referenced
this pull request
Jun 3, 2024
… com… (OpenAtomFoundation#2603) * Add the output data of command 'info keyspace 1' to the output of command 'info all'
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
… com… (OpenAtomFoundation#2603) * Add the output data of command 'info keyspace 1' to the output of command 'info all'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'info keyspace 0' output data to 'info all' #2587