fix:slave parse tnx binlog failed #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheniujh
reviewed
May 9, 2024
| Expect(r2.Err()).NotTo(HaveOccurred()) | ||
| Expect(r2.Val()).To(Equal([]interface{}{"OK", "OK"})) | ||
|
|
||
| time.Sleep(100 * time.Millisecond) |
There was a problem hiding this comment.
这里等待时间可以改大一些，比如3s，避免线上机器因为性能差同步不及时导致测试失败
There was a problem hiding this comment.
这里等待时间可以改大一些，比如3s，避免线上机器因为性能差同步不及时导致测试失败
done
| Expect(setkey1.Err()).NotTo(HaveOccurred()) | ||
| Expect(setkey1.Val()).To(Equal("QUEUED")) | ||
|
|
||
| setkey2 := clientMaster.Set(ctx, "key2", "value2", 0) |
There was a problem hiding this comment.
建议这些key加上前缀, 让他独特一些，避免slave本身就有这些key而导致误判
There was a problem hiding this comment.
建议这些key加上前缀, 让他独特一些，避免slave本身就有这些key而导致误判
done
| @@ -738,6 +738,48 @@ var _ = Describe("should replication ", func() { | |||
| Expect(r.Err()).To(MatchError("ERR EXEC without MULTI")) | |||
|
|
|||
dingxiaoshuai123
approved these changes
May 9, 2024
AlexStocks
approved these changes
May 9, 2024
chejinge
added a commit
that referenced
this pull request
May 9, 2024
* fix:slave parse tnx binlog failed * fix:slave parse tnx binlog failed --------- Co-authored-by: chejinge <chejinge@360.cn>
chenbt-hz
pushed a commit
to chenbt-hz/pika
that referenced
this pull request
Jun 3, 2024
* fix:slave parse tnx binlog failed * fix:slave parse tnx binlog failed --------- Co-authored-by: chejinge <chejinge@360.cn>
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* fix:slave parse tnx binlog failed * fix:slave parse tnx binlog failed --------- Co-authored-by: chejinge <chejinge@360.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2643