Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix on bad request message being ignored #2209

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

Dimfacion
Copy link
Member

@Dimfacion Dimfacion commented Jan 14, 2025

Proposed changes

  • Fix to allow bad request message being displayed if filled

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.69%. Comparing base (51f58ec) to head (c97c26b).
Report is 33 commits behind head on release/current.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/current    #2209   +/-   ##
==================================================
  Coverage              32.69%   32.69%           
  Complexity              1513     1513           
==================================================
  Files                    582      582           
  Lines                  18033    18033           
  Branches                1156     1156           
==================================================
  Hits                    5896     5896           
  Misses                 11874    11874           
  Partials                 263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dimfacion Dimfacion changed the base branch from master to release/current January 21, 2025 13:00
@Dimfacion Dimfacion merged commit bcfa553 into release/current Jan 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants