Hotfix/weird logs

[hjoaquim]

Description

• Summary of the change / bug fix.
  On the SDK, we were getting logs messages printed on notebooks - this was because notebooks come with handlers by default (see Notebook has a root logging handler installed by default ipython/ipython#8282 for more context).
  The solution proposed on this PR is to clean the root logger handler, if any, during setup_handlers().

Also, took the opportunity to:

• filter empty credentials incoming from the hub

• encapsulated the usage of a variable that is created of the cost of calling a function inside a function so we don't have unnecessary executions during initialization

• Link # issue, if applicable.
  NA

• Screenshot of the feature or the bug before/after fix, if applicable.
  Before
  

After

• Relevant motivation and context.
  🐛 ☠️

• List any dependencies that are required for this change.
  NA

How has this been tested?

Just initialize the SDK: from openbb_terminal.sdk import openbb

• Please describe the tests that you ran to verify your changes.
• Provide instructions so we can reproduce.
• Please also list any relevant details for your test configuration.

• Make sure affected commands still run in terminal
• Ensure the SDK still works
• Check any related reports

Checklist:

• I have adhered to the GitFlow naming convention and my branch name is in the format of feature/feature-name or hotfix/hotfix-name.
• Update our documentation following these guidelines. Update any user guides that are affected by the changes.
• Update our tests following these guidelines.
• Make sure you are following our CONTRIBUTING guidelines.
• If a feature was added make sure to add it to the corresponding integration test script.

Others

• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.

[piiq]

Thanks @hjoaquim

I was seeing this beyond ipython terminal and notebooks. Let me check the wheel

15 mins later...

Ok, the wheel does not give this error when pip installed

[piiq]

yeah, i also thought about this. i didn't like how it was implemented as a constant but it's actually loading stuff from disk

[hjoaquim]

Yes, it is - my issue with it was that this file gets "loaded" before the loggers are set up, and since get_erc20_tokens gets called and will try to log something, might lead to an unexpected behavior.

[piiq]

@hjoaquim you fix mypy yourself or you need a hand?

[hjoaquim]

@hjoaquim you fix mypy yourself or you need a hand?

No worries, I'm on it. Thank you, @piiq 🦋

[hjoaquim]

Regarding 3cf7751, @montezdesousa needed to go back and define fields as it was to make mypy happy. Is it ok to filter incoming empty credentials like this, so it don't clash with the CredentialsModel definition?